Improved localisation #2177
Closed
Improved localisation #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code ('en') if specific code ('en-us') doesn not match
Closed
| }); | ||
| this.languages_ = languagesToLower; | ||
| } | ||
| else { |
There was a problem hiding this comment.
This else should be on the same line as the closing curly-brace of the preceding if.
|
I think there may be an additional whitespace issue in here (@gkatsev, how's that code formatting build step going?) but looks good to me. |
| if (options['languages']) { | ||
| // Normalise player option languages to lowercase | ||
| let languagesToLower = {}; | ||
| Object.getOwnPropertyNames(options['languages']).forEach(function(value,index,array){ |
|
It's coming along slowly. If someone wanted to run it locally, it's doable by installing |
|
Fixed those and other issues flagged by |
|
Suggested some changes here: mister-ben#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1873, which got messy after being stagnant so long...
de-DEtranslation, usedeif available.en-usbut Chrome and Firefox useen-US, these should be treated the same.addLanguage()is still effective for players that had languages set as a setup option. Player-local languages take precedence.